Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Hotwire submissions add and delete flow #3925

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix: Hotwire submissions add and delete flow #3925

merged 1 commit into from
Jul 10, 2023

Conversation

KevinMulhern
Copy link
Member

Because:

  • The add button was not displaying again after deleting your submission.

This commit:

  • Breaks the add submission button out into its own partial so it can be rendered within turbo streams.
  • Adds a destroy turbo stream response to remove the submissions and display the add button.
  • Add a couple of expectations to ensure this cannot regress in the future.

@KevinMulhern
Fix: Hotwire submissions add and delete flow
7938a35 
Because:
* The add button was not displaying again after deleting your submission.

This commit:
* Breaks the add submission button out into its own partial so it can be rendered within turbo streams.
* Adds a destroy turbo stream response to remove the submissions and display the add button.
* Add a couple of expectations to ensure this cannot regress in the future.
@KevinMulhern KevinMulhern self-assigned this Jul 7, 2023
@KevinMulhern KevinMulhern added the Type: Bug Involves something that isn't working as intended label Jul 7, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3925 July 7, 2023 23:12 Inactive
@KevinMulhern KevinMulhern merged commit 3c3bd6f into main Jul 10, 2023
2 checks passed
@KevinMulhern KevinMulhern deleted the fix/hotwire-submissions-adding-and-delete branch July 10, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CouchofTomato CouchofTomato CouchofTomato approved these changes

Assignees

@KevinMulhern KevinMulhern

Labels
Type: Bug Involves something that isn't working as intended
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinMulhern @CouchofTomato